[csharp] Extend HostConfiguration with additional AddApiHttpClients signatures#22500
Open
daberni wants to merge 1 commit intoOpenAPITools:masterfrom
Open
[csharp] Extend HostConfiguration with additional AddApiHttpClients signatures#22500daberni wants to merge 1 commit intoOpenAPITools:masterfrom
daberni wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
6eb5add to
ed56c22
Compare
ed56c22 to
132cc6d
Compare
Contributor
Author
|
@wing328 it looks like the suggested technical committee members are quite inactive at the moment. What would be the best way to still be able to contribute to these projects when there is no one approving the pull requests? |
Contributor
|
LGTM, lets try it @wing328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds new Method signatures to the
HostConfigurationin regards ofAddApiHttpClientsto support also theAddHttpClient(Action<IServiceProvider, HttpClient> configureClient)variant. This allows to access theServiceProviderduring configuration which can be very benefitial.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)